[PATCH] D68013: [PatternMatch] Make m_Br more flexible, add matchers for BB values.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/include/llvm/IR/PatternMatch.h:682-683
+
+/// Match a specific integer value or vector with all elements equal to
+/// the value.
+inline specific_bbval m_SpecificBB(BasicBlock *BB) {
----------------
lebedev.ri wrote:
> This comment seems outdated.
Thanks, updated!


================
Comment at: llvm/include/llvm/IR/PatternMatch.h:1375-1379
+template <typename Cond_t, typename TrueBlock_t, typename FalseBlock_t>
+struct brc_match {
   Cond_t Cond;
-  BasicBlock *&T, *&F;
+  TrueBlock_t T;
+  FalseBlock_t F;
----------------
lebedev.ri wrote:
> Precommit
Done, split off to a separate commit, to be committed once this one is accepted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68013/new/

https://reviews.llvm.org/D68013