[PATCH] D68012: [llvm-readobj/llvm-readelf] - .stack_sizes: demangle symbol names in warnings reported.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 25 05:55:48 PDT 2019


grimar added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:4786
           createError("cannot identify the section for relocation symbol " +
-                      SymName),
+                      getSymbolName(*RelocSym)),
           FileStr);
----------------
jhenderson wrote:
> Since we're now demangling these symbols, I wonder if it would make sense here and in the other warning to quote the symbol names, because demangled names can be phrases rather than individual names. Quoting would make the name easier to read, I think.
Sounds good. Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68012/new/

https://reviews.llvm.org/D68012





More information about the llvm-commits mailing list