[PATCH] D68018: [yaml2elf] - Support describing .stack_sizes sections using unique suffixes.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with two suggestions.



================
Comment at: test/tools/yaml2obj/elf-stack-sizes.yaml:231
+
+## Check we can describe .stack_sizes sections using unique suffixes.
+
----------------
Maybe worth saying "describe multiple .stack_sizes sections..."


================
Comment at: test/tools/yaml2obj/elf-stack-sizes.yaml:234
+# RUN: yaml2obj --docnum=10 %s -o %t10
+# RUN: llvm-readobj --sections --section-data %t10 | FileCheck %s --check-prefix=SUFFIX
+
----------------
I think "UNIQUE" might be a better prefix here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68018/new/

https://reviews.llvm.org/D68018