[PATCH] D67958: [yaml2obj] - Add a Size field for StackSizesSection.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 25 04:24:38 PDT 2019


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: test/tools/yaml2obj/elf-stack-sizes.yaml:215
 
-## Check we must specify either "Content" or "Entries" tag when describing .stack_sizes.
+## Check we must specify either "Content", "Entries" or "Size" tag when describing .stack_sizes.
 
----------------
MaskRay wrote:
> either ... or -> one of
I do not mid to rephrase and will do it before commit, but do you mean it is not grammarly correct?
(I think it is commonly used: https://www.grammarphobia.com/blog/2017/08/either-neither.html)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67958/new/

https://reviews.llvm.org/D67958





More information about the llvm-commits mailing list