[PATCH] D68016: [docs][llvm-strings] Clarify "printable character" wording

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 25 03:55:38 PDT 2019


jhenderson created this revision.
jhenderson added reviewers: MaskRay, rupprecht.
Herald added a project: LLVM.

The --bytes option uses the phrase "printable ASCII characters", but the description section used simply "printable characters". To avoid any confusion about locale impacts etc, this change adopts the formers phrasing in both places. It also fixes a minor grammar issue in the description.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68016

Files:
  llvm/docs/CommandGuide/llvm-strings.rst


Index: llvm/docs/CommandGuide/llvm-strings.rst
===================================================================
--- llvm/docs/CommandGuide/llvm-strings.rst
+++ llvm/docs/CommandGuide/llvm-strings.rst
@@ -14,8 +14,8 @@
 :program:`llvm-strings` is a tool intended as a drop-in replacement for GNU's
 :program:`strings`, which looks for printable strings in files and writes them
 to the standard output stream. A printable string is any sequence of four (by
-default) or more printable characters. The end of the file, or any other byte
-terminates the current sequence.
+default) or more printable ASCII characters. The end of the file, or any other
+byte, terminates the current sequence.
 
 :program:`llvm-strings` looks for strings in each ``input`` file specified.
 Unlike GNU :program:`strings` it looks in the entire input file, regardless of


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68016.221712.patch
Type: text/x-patch
Size: 851 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190925/f7c14b69/attachment.bin>


More information about the llvm-commits mailing list