[PATCH] D67962: [llvm-readobj] - Don't crash when dumping .stack_sizes and unable to find a relocation resolver.

Wed Sep 25 03:16:01 PDT 2019

jhenderson added a comment.

In D67962#1682178 <https://reviews.llvm.org/D67962#1682178>, @grimar wrote:

> In D67962#1682098 <https://reviews.llvm.org/D67962#1682098>, @jhenderson wrote:
>
> > I'm beginning to think that stack-sizes.test needs breaking up into smaller tests...!
>
>
> I would probably start from splitting all the warning/error testing to `stack-sizes-err.test`.
>  They seem to take more than half (and still do not test all of the possible messages).

That would be a good start. I'd probably split the warning/error testing further into related warnings though. For example, invalid relocations could be tested in their own test.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67962/new/

https://reviews.llvm.org/D67962