[zorg] r372342 - The LLD buildbot has some tests that are not reliable.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 25 03:11:28 PDT 2019


Do you know which test was failing before? I think if a test is flaky, it
could mean that lld (rather than the test) is actually flaky perhaps due to
multi-threading safety.

On Fri, Sep 20, 2019 at 2:38 AM Galina Kistanova via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: gkistanova
> Date: Thu Sep 19 10:39:54 2019
> New Revision: 372342
>
> URL: http://llvm.org/viewvc/llvm-project?rev=372342&view=rev
> Log:
> The LLD buildbot has some tests that are not reliable.
> Hopefully reducing the number of threads for the test will fix the issue.
> It seems that the quotes around the parameters means it tries to take
> everything as one argument. Bu using -j we can actually pass everything as
> one argument by attaching the j to the sv.
>
> Patch by Stefan Pintilie.
>
> Modified:
>     zorg/trunk/buildbot/osuosl/master/config/builders.py
>
> Modified: zorg/trunk/buildbot/osuosl/master/config/builders.py
> URL:
> http://llvm.org/viewvc/llvm-project/zorg/trunk/buildbot/osuosl/master/config/builders.py?rev=372342&r1=372341&r2=372342&view=diff
>
> ==============================================================================
> --- zorg/trunk/buildbot/osuosl/master/config/builders.py (original)
> +++ zorg/trunk/buildbot/osuosl/master/config/builders.py Thu Sep 19
> 10:39:54 2019
> @@ -933,7 +933,7 @@ def _get_lld_builders():
>           'factory':
> UnifiedTreeBuilder.getCmakeWithNinjaMultistageBuildFactory(
>                                      extra_configure_args=[
>                                          '-DLLVM_ENABLE_ASSERTIONS=ON',
> -                                        '-DLLVM_LIT_ARGS="-sv
> --threads=10"'],
> +                                        '-DLLVM_LIT_ARGS="-svj 10"'],
>                                      depends_on_projects=['llvm', 'clang',
> 'lld']),
>           'category'   : 'lld'},
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190925/794c26b2/attachment.html>


More information about the llvm-commits mailing list