[PATCH] D67962: [llvm-readobj] - Don't crash when dumping .stack_sizes and unable to find a relocation resolver.

Wed Sep 25 02:37:04 PDT 2019

MaskRay accepted this revision.
MaskRay added inline comments.

================
Comment at: test/tools/llvm-readobj/stack-sizes.test:601
+## Check that we report an error when we unable to resolve a relocation for a given ELF arch.
+## Here we have a valid 64-bit relocation used in a 32-bit object.
+
----------------
jhenderson wrote:
> I'd probably just get rid of "valid" since a 64-bit relocation in a 32-bit object doesn't really make sense.
ELFCLASS32+EM_X86_64 can mean x32 ABI (`x86_64-linux-gnux32`), so not entirely "invalid"... Though it is of ELFDATA2MSB, the big-endian stuff makes it invalid.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67962/new/

https://reviews.llvm.org/D67962