[PATCH] D67664: [ARM] Ensure we do not attempt to create lsll #0

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 25 02:26:24 PDT 2019


dmgreen added a comment.

Thanks.

We did originally try to make this work with the SHL_PARTS nodes, and got quite far if my memory is correct. There was a certain amount of target independent code that was changed to keep them legal and prevent optimisations that we didn't want to happen from going off.  My memory is fuzzy as to what the final showstopper was (if there really was one). Maybe something about treating LSRL as a LSLL with a negated operand, with the SRL_PARTS not there really being legal?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67664/new/

https://reviews.llvm.org/D67664





More information about the llvm-commits mailing list