[PATCH] D67656: [llvm-objcopy] Add --set-section-alignment

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/set-section-alignment.test:7-9
+# CHECK:      Name: .foo
+# CHECK:      AddressAlignment:
+# CHECK-SAME: 4
----------------
MaskRay wrote:
> rupprecht wrote:
> > Same for all the -SAME in this file
> If I do not use `-SAME`, I'll have to enumerate all fields between Name and AddressAlignment, with `-NEXT:`. I think `-SAME` is clearer.
> 
> `CHECK: AddressAlignment: 4` can match something like:
> 
> ```
> Name: foo
> AddressAlignment: 8
> 
> Name: bar
> AddressAlignment: 4
> ```
+1 to keeping `-SAME`. I find it less readable if I have to read lots of irrelevant fields. Maybe indenting the number might make it more readable, but I'm not sure:

```
# CHECK:      Name: .foo
# CHECK:      AddressAlignment:
# CHECK-SAME:                   4
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67656/new/

https://reviews.llvm.org/D67656