[PATCH] D67989: [ValueTracking] Improve pointer offset computation for cases of same base

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:5759
+  // as in "P" and "gep P, 1".
+  // Also do this itertively to handle the the following case:
+  //   Ptr_t1 = GEP Ptr1, c1
----------------
`iteratively`


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:5763
+  //   Ptr2 = GEP Ptr_t2, c3
+  // where will return c1+c2+c3.
+  auto getOffsetFromBase = [&DL](const GEPOperator *GEP,
----------------
`it will` or `we'll`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67989/new/

https://reviews.llvm.org/D67989