[PATCH] D67586: Replace uses of std::iterator with explicit using

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Looks good!

  // P0174
  Update from Jacksonville, 2016:
  
  Poll: Deprecate iterator for C++17??
  
  SF	F	N	A	SA
  6	10	1	0	0



In D67586#1670541 <https://reviews.llvm.org/D67586#1670541>, @hamzasood wrote:

> I just realised that the unqualified calls worked because a base class of type `std::iterator` means that functions in `namespace std` will be found by ADL. So you can ignore the last paragraph in the patch summary.


You can edit the summary to mention that due to the loss of ADL you have to prepend `std::` in a few places.

Have you done a check-all (llvm,clang,lldb,lld,etc) to ensure nothing else breaks?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67586/new/

https://reviews.llvm.org/D67586