[PATCH] D67819: [LNT] Python 3 support: adapt to zip returning an iterator

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 20:49:30 PDT 2019


hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.

LGTM with suggestion to update commit message.



================
Comment at: lnt/server/reporting/report.py:11
 
-def pairs(list):
-    return zip(list[:-1], list[1:])
+def pairs(l):
+    """Make an iterable of all pairs of consecutive elements in l."""
----------------
I agree that a rename would help. Please update the commit message with the rationale.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67819/new/

https://reviews.llvm.org/D67819





More information about the llvm-commits mailing list