[PATCH] D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64

Jason Molenda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 18:34:59 PDT 2019


jasonmolenda added a comment.

In D67892#1680317 <https://reviews.llvm.org/D67892#1680317>, @labath wrote:

> In either case, it's sad that there are no tests breaking due to this. Ideally we'd have a small arm64 macho core file with well known register values that we could just assert are read correctly. You probably don't have the means to create such a core file, so it's not fair to ask you to do that, but it would be great if one of the apple folks added a test like that.


I have a little program in macosx/lc-note that can create a corefile with a register context.  I'll base something on that to create an arm64 mach-o corefile (or any architecture) and write a simple test to see if we can get an expected register value out.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67892/new/

https://reviews.llvm.org/D67892





More information about the llvm-commits mailing list