[PATCH] D67747: [utils] Add a script to upload to Phabricator.

David L. Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 18:05:53 PDT 2019


dlj added a comment.

Alright, here's what's changed:

- I think the `--edit --verbatim` logic works now. At least, I was able to update the revision and the diff. :-)
- Moved to `utils/git-phab`, and dropped all the Python 2 compatibility stuff.

Here's what might be next steps:

- I think it might make sense to split apart the 'diff' command, since that would (probably) simplify the common uses. Tentatively, I could imagine:
  - `git phab update`: Pull the revision from Phabricator and amend the local HEAD commit message.
  - `git phab reword`: Pull the revision from Phabricator, interactively edit the commit message, amend the local HEAD, then update the revision on Phabricator.
  - `git phab diff`: Uploads a new diff. If a revision is found, attaches the diff and optionally does the equivalent of "reword."
- I also need to work on using something other than a raw diff. That's going to be pretty major, though, so I'm going to defer that for now.
- Obviously, add `git phab patch`. :-) But this relies on uploading non-raw diffs. (I think. There are some details in the Conduit API between new and old methods that matter. I don't know how many of those will go away if we can just upgrade Phabricator, though.)
- One thing I've done in the past was to add tags for differential revisions. That should be easy to do as a follow-up, but I don't know how useful it is to keep the tags around.
- I've sprinkled a few more TODOs as well. I don't plan to address those right away, since they should be easy to add once the overall flow solidifies. (Plus, they might make it harder to restructure things in the mean time...)

Nico, Ray -- let me know what you would prefer next. I can keep iterating on it now, or I can commit and start on follow-ups.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67747/new/

https://reviews.llvm.org/D67747





More information about the llvm-commits mailing list