[llvm] r372226 - Follow-up to r372209: Use single quotes for host_ldflags in the lit config

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 16:54:45 PDT 2019


Hans Wennborg via llvm-commits <llvm-commits at lists.llvm.org> writes:
> Author: hans
> Date: Wed Sep 18 07:12:59 2019
> New Revision: 372226
>
> URL: http://llvm.org/viewvc/llvm-project?rev=372226&view=rev
> Log:
> Follow-up to r372209: Use single quotes for host_ldflags in the lit config
>
> HOST_LDFLAGS is now using double quotes, and that would break the lit
> config file.

This broke -DLLVM_BUILD_INSTRUMENTED_COVERAGE, so I attempted to fix it
in r372791. PTAL.

> Modified:
>     llvm/trunk/test/lit.site.cfg.py.in
>
> Modified: llvm/trunk/test/lit.site.cfg.py.in
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/lit.site.cfg.py.in?rev=372226&r1=372225&r2=372226&view=diff
> ==============================================================================
>
> --- llvm/trunk/test/lit.site.cfg.py.in (original)
> +++ llvm/trunk/test/lit.site.cfg.py.in Wed Sep 18 07:12:59 2019
> @@ -29,7 +29,8 @@ config.llvm_bindings = "@LLVM_BINDINGS@"
>  config.host_os = "@HOST_OS@"
>  config.host_cc = "@HOST_CC@"
>  config.host_cxx = "@HOST_CXX@"
> -config.host_ldflags = "@HOST_LDFLAGS@"
> +# Note: ldflags can contain double-quoted paths, so must use single quotes here.
> +config.host_ldflags = '@HOST_LDFLAGS@'
>  config.llvm_use_intel_jitevents = @LLVM_USE_INTEL_JITEVENTS@
>  config.llvm_use_sanitizer = "@LLVM_USE_SANITIZER@"
>  config.have_zlib = @HAVE_LIBZ@
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list