[PATCH] D28596: [compiler-rt] General definition for weak functions.

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 14:36:08 PDT 2019


morehouse added a comment.

In D28596#1680946 <https://reviews.llvm.org/D28596#1680946>, @rnk wrote:

> I see. I audited the other instances of SANITIZER_INTERFACE_WEAK_DEF, and they all seem to be properly namespaced into `__asan_`, `__sanitizer_`, etc.
>
> Do you (or someone else from dynamic-tools) mind driving the fix for this, since you control the internal integration for this and would know where to add the missing test? Again, sorry for the breakage.


Proposed fix in https://reviews.llvm.org/D67987.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D28596/new/

https://reviews.llvm.org/D28596





More information about the llvm-commits mailing list