[PATCH] D67974: [Dominators][AMDGPU] Don't use virtual exit node in findNearestCommonDominator. Cleanup MachinePostDominators.

Michael Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 14:03:31 PDT 2019


hliao requested changes to this revision.
hliao added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/CodeGen/MachinePostDominators.cpp:53
+  assert(!Blocks.empty());
+  assert(llvm::all_of(Blocks, [](MachineBasicBlock *B) { return B; }) &&
+         "Invalid block found");
----------------
the assertion here is still redundant, as findNearestCommonDominator also asserts on both operands must not be null.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67974/new/

https://reviews.llvm.org/D67974





More information about the llvm-commits mailing list