[PATCH] D66280: [llvm-objcopy][MachO] Support indirect symbol table

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht accepted this revision.
rupprecht added a comment.
This revision is now accepted and ready to land.

LGTM, but @alexshap can you review the Mach-O logic?



================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOReader.cpp:262
+    if ((Index &
+        (MachO::INDIRECT_SYMBOL_LOCAL | MachO::INDIRECT_SYMBOL_ABS)) != 0)
+      O.IndirectSymTable.Symbols.emplace_back(Index, None);
----------------
For readability, you might want to extract `uint32_t AbsOrLocalMask = MachO::INDIRECT_SYMBOL_LOCAL | MachO::INDIRECT_SYMBOL_ABS`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66280/new/

https://reviews.llvm.org/D66280