[PATCH] D67656: [llvm-objcopy] Add --set-section-alignment
Alex Brachet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 24 12:34:17 PDT 2019
abrachet added a comment.
Looks like the author of that patch submitted a new patch to accept alignment of power of twos not 2^<align> after James’ comment :)
That patch will give an error if the given <align> is not a power of two Including 0. Do you have thoughts on erroring for non powers excluding 0?
Also, it might be worth adding a test setting alignment to a negative value to make sure `StringRef::getAsInteger<unsigned>` properly fails.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67656/new/
https://reviews.llvm.org/D67656
More information about the llvm-commits
mailing list