[PATCH] D67925: [FPEnv] Strict FP tests should use the requisite function attributes
Kevin P. Neal via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 24 12:20:03 PDT 2019
kpn added a comment.
In D67925#1681156 <https://reviews.llvm.org/D67925#1681156>, @cameron.mcinally wrote:
> Would it be better to do an `attributes #0 = { ...}` style change? E.g.:
>
> define double @f5(double %a) #0 {
> ...
> }
>
> attributes #0 = {strictfp noimplicitfloat}
>
I like that syntax since it is much more compact. I imagine I'll need to update the tests after D67839 <https://reviews.llvm.org/D67839> is concluded. I'll give this syntax a spin then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67925/new/
https://reviews.llvm.org/D67925
More information about the llvm-commits
mailing list