[PATCH] D67926: Fix endianness handling in AVR MC
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 24 12:04:19 PDT 2019
efriedma added a comment.
How have you been testing this? How many regression test failures are there on s390x? The first version of the patch should not have passed all the regression tests on a big-endian target, I think. (In particular, it should not have worked for 32-bit instructions, like llvm/test/MC/AVR/inst-jmp.s).
Probably want to wait for Dylan to comment, but looks fine. (Changing the code to use support::endian::write isn't necessary, but it's more readable.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67926/new/
https://reviews.llvm.org/D67926
More information about the llvm-commits
mailing list