[PATCH] D67853: [PowerPC][XCOFF] Fix expansion of LWZtoc Pseudo for AIX.
Sean Fertile via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 24 11:13:58 PDT 2019
sfertile marked an inline comment as done.
sfertile added a comment.
In D67853#1680848 <https://reviews.llvm.org/D67853#1680848>, @Xiangling_L wrote:
> Just a minor nit:
>
> clean up "local_unnamed_addr" in testcase? or even "dso_local"?
Done, and thanks for the review.
================
Comment at: llvm/test/CodeGen/PowerPC/lower-globaladdr32-aix-asm.ll:7
+
+define dso_local void @test() local_unnamed_addr {
+ %1 = load i32, i32* @b
----------------
Xiangling_L wrote:
> Clean up this "local_unnamed_addr" as well?
I got sloppy and missed this one. I've cleaned up in the final commit.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67853/new/
https://reviews.llvm.org/D67853
More information about the llvm-commits
mailing list