[PATCH] D67855: [X86] Add new calling convention that guarantees tail call optimization

Dwight Guth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 09:25:50 PDT 2019


dwightguth added a comment.

I added tests for musttail and mixed calling conventions. But I'm a little unsure what the correct behavior should be here for disable-tail-calls. When you do a musttail call, disable-tail-calls is ignored. When you do a fastcc call with -tailcallopt, disable-tail-calls is not ignored. This seems a little inconsistent to me, but is beyond the scope of this revision. Which of these two behaviors should be implemented by tailcc, though? Currently it does the same thing as fastcc with -tailcallopt. I can add a test for that behavior, but if we want the other behavior, I need to know before I write that test because it affects the test's output.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67855/new/

https://reviews.llvm.org/D67855





More information about the llvm-commits mailing list