[PATCH] D67552: [LangRef] Clarify absence of rounding guarantees for fmuladd.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 07:38:20 PDT 2019


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM (though I think we're waiting for @reames).



================
Comment at: llvm/docs/LangRef.rst:13956
+whether rounding will be performed between the multiplication and addition
+steps. Fusion is not guaranteed, even if the target platform supports it.
+If a fused multiply-add is required, the corresponding
----------------
spatel wrote:
> Worth adding a sentence to explain *why* we have this intrinsic at all? Something like:
> "The optional fusion gives flexibility to the IR optimizer and code generator to select the best-performing target code sequence." 
On 2nd thought, strike that suggestion - it's redundant with the text in the 'Overview' above this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67552/new/

https://reviews.llvm.org/D67552





More information about the llvm-commits mailing list