[PATCH] D67301: [LLD] Use the unified llvm demangle frontend function. NFC.

Tue Sep 24 05:40:24 PDT 2019

mstorsjo marked an inline comment as done.
mstorsjo added inline comments.

================
Comment at: lld/COFF/Symbols.cpp:39-40
+    std::string demangled = demangle(demangleInput, /*strictPrefix=*/true);
+    if (demangled != demangleInput)
+      return prefix + demangled;
   }
----------------
ruiu wrote:
> Does this mean `__imp_foo` is printed as just `__imp_foo` but any C++ mangled name after `__imp_` is printed as `__declspec(dllimport) ...`? It feels to me that always "demangle" __imp prefix is more consistent.
Yes, that's correct - that's how it's done right now.

Sure, we could change that, but that would be a separate change, as this tries to be an NFC refactoring.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67301/new/

https://reviews.llvm.org/D67301