[PATCH] D67757: [yaml2obj/obj2yaml] - Add support for .stack_sizes sections.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 24 05:15:42 PDT 2019
grimar added inline comments.
================
Comment at: lib/ObjectYAML/ELFYAML.cpp:1179
+ if (const auto *SS = dyn_cast<ELFYAML::StackSizesSection>(Section.get())) {
+ if (SS->Content && SS->Entries)
+ return ".stack_sizes can't have both Content and Entries tags";
----------------
jhenderson wrote:
> If we're allowing people to specify a Content field, it seems reasonable to also allow specification of a Size field, with the content set to zeroes, if not otherwise filled in by Content.
I posted a follow-up: D67958
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67757/new/
https://reviews.llvm.org/D67757
More information about the llvm-commits
mailing list