[PATCH] D67849: [InstCombine] (a+b) < a && (a+b) != 0 -> (0-b) < a iff a/b != 0 (PR43259)

Tue Sep 24 04:59:27 PDT 2019

xbolva00 added inline comments.

================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1064

+  auto IsKnownNonZero = [&](Value *V) {
+    return isKnownNonZero(V, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT);
----------------
lebedev.ri wrote:
> xbolva00 wrote:
> > I think we dont need this lambda.. Just inline it.
> I don't see why spelling all that each time is better.
So just add a new overload which takes

isKnownNonZero(V, Q)?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67849/new/

https://reviews.llvm.org/D67849