[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added a comment.

In D67613#1680176 <https://reviews.llvm.org/D67613#1680176>, @uabelho wrote:

> In D67613#1679879 <https://reviews.llvm.org/D67613#1679879>, @xbolva00 wrote:
>
> > /srv/llvm-buildbot-srcatch/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/tools/clang/tools/extra/modularize/Modularize.cpp:583:13: warning: enumeration values 'lang_cxx_11' and 'lang_cxx_14' not handled in switch [-Wswitch]
> >  1 warning generated.
>
>
> We also get that warning when compiling with clang 8:
>
>   ../../clang-tools-extra/modularize/Modularize.cpp:583:13: error: enumeration values 'lang_cxx_11' and 'lang_cxx_14' not handled in switch [-Werror,-Wswitch]
>       switch (D->getLanguage()) {
>               ^
>   1 error generated.
>




In D67613#1680398 <https://reviews.llvm.org/D67613#1680398>, @uabelho wrote:

> In D67613#1680176 <https://reviews.llvm.org/D67613#1680176>, @uabelho wrote:
>
> > In D67613#1679879 <https://reviews.llvm.org/D67613#1679879>, @xbolva00 wrote:
> >
> > > /srv/llvm-buildbot-srcatch/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/tools/clang/tools/extra/modularize/Modularize.cpp:583:13: warning: enumeration values 'lang_cxx_11' and 'lang_cxx_14' not handled in switch [-Wswitch]
> > >  1 warning generated.
> >
> >
> > We also get that warning when compiling with clang 8:
> >
> >   ../../clang-tools-extra/modularize/Modularize.cpp:583:13: error: enumeration values 'lang_cxx_11' and 'lang_cxx_14' not handled in switch [-Werror,-Wswitch]
> >       switch (D->getLanguage()) {
> >               ^
> >   1 error generated.
> >
>
>
> I did something about it in r372714. Please take a look and see if it should be fixed differently.


Hi Thanks for doing this, I got occupied by something else.  that seems good.
Thanks again!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67613/new/

https://reviews.llvm.org/D67613