[PATCH] D67656: [llvm-objcopy] Add --set-section-alignment

Mon Sep 23 23:40:08 PDT 2019

MaskRay added a comment.

In D67656#1680145 <https://reviews.llvm.org/D67656#1680145>, @abrachet wrote:

> In D67656#1680134 <https://reviews.llvm.org/D67656#1680134>, @MaskRay wrote:
>
> > In D67656#1679119 <https://reviews.llvm.org/D67656#1679119>, @jhenderson wrote:
> >
> > > I'm very happy to see this change, but I hesitate to diverge in behaviour from GNU's behaviour. I certainly prefer --set-section-alginment to set it to an arbitrary alignment though, so I think we need to lean on the GNU maintainers to change their end.
> >
> >
> > The behavior difference is also my concern, so I hold off on this patch. I argue at https://sourceware.org/bugzilla/show_bug.cgi?id=24942#c9 that --set-section-alignment .foo=8 => sh_addralign=256 is counterintuitive. Please chime in if you feel the same.
>
>
> When you say chime in do you mean here or on that bug report?

I mean https://sourceware.org/bugzilla/show_bug.cgi?id=24942 , the bugzilla ticket where people discuss the --set-section-alignment option in GNU objcopy. Can you please forward the comment there:) ?

If you'd like to play with GNU objcopy:

  git clone git://sourceware.org/git/binutils-gdb.git
  cd binutils-gdb
  mkdir Debug
  ../configure --enable-binutils --disable-gas --disable-gdb --disable-gold --disable-ld CFLAGS='-O0 -g'
  make -j all-binutils
  # Built binutils/objcopy

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67656/new/

https://reviews.llvm.org/D67656