[PATCH] D67241: Regex: Make "match" and "sub" const member functions

Nicolas Guillemot via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 23 16:07:50 PDT 2019


nlguillemot added a comment.

In D67241#1679847 <https://reviews.llvm.org/D67241#1679847>, @thopre wrote:

> In D67241#1679348 <https://reviews.llvm.org/D67241#1679348>, @nlguillemot wrote:
>
> > friendly reminder ping
>
>
> My bad, I misunderstood you and thought you'd do a patch to  implement the "Create a Regex and immediately throw it away" idiom and rebase that one on top of it.


I could do that. By "rebase that one on top of it", do you mean to include the additional changes in this same review?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67241/new/

https://reviews.llvm.org/D67241





More information about the llvm-commits mailing list