[PATCH] D67133: [GlobalISel]: Fix some non determinism exposed in CSE due to not notifying observers about mutations + add verification for CSE

Mon Sep 23 16:02:51 PDT 2019

aemerson added a comment.

In D67133#1679497 <https://reviews.llvm.org/D67133#1679497>, @aditya_nandakumar wrote:

> In D67133#1677499 <https://reviews.llvm.org/D67133#1677499>, @aemerson wrote:
>
> > Ping. Can we combine the delegate and observer installers?
>
>
> Thanks Amara for the feedback. The reason I haven't responded here (or committed this) is that I haven't had the chance to track and fix the issues in the various backends where this fails (probably missing Observer calls). Maybe for now, I will disable the verification by default and get this patch in, and we can work on enabling it by default in a follow up patch?

Either way is fine for me, it can wait until the bugs are found.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67133/new/

https://reviews.llvm.org/D67133