[PATCH] D63676: Disable hosting MI to hotter basic blocks

[Victor Huang via Phabricator via llvm-commits]

NeHuang marked 9 inline comments as done.
NeHuang added a comment.

Thanks @nemanjai 's review. Addressed all the comments and updated the test cases accordingly.



================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:85
+
+enum NotHoistDueToBlockHotnessType { Disable, Enable_PGO, Enable };
+
----------------
nemanjai wrote:
> Similarly to below, the naming is a bit strange. Perhaps:
> ```
> enum DisableHoistingToHotterBlocks { None, PGO, All };
> ```
> or
> ```
> enum DisableHoistingToHotterBlocks { None, PGO_Only, Static };
> ```
> (although I prefer the former).
- Using "DisableHositingToHotterBlocksType" for enum 
- Using"NONE" instead of "None" to avoid ambiguity.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63676/new/

https://reviews.llvm.org/D63676