[PATCH] D67529: [TextAPI] Introduce TBDv4

[Juergen Ributzka via Phabricator via llvm-commits]

ributzka added inline comments.


================
Comment at: llvm/unittests/TextAPI/TextStubV4Tests.cpp:308
+  auto Result =
+      TextAPIReader::get(MemoryBufferRef(tbd_target_macabi, "Test.tbd"));
+  EXPECT_TRUE(!!Result);
----------------
s/macabi/maccatalyst


================
Comment at: llvm/unittests/TextAPI/TextStubV4Tests.cpp:372
+                                      "install-name: Test.dylib\n"
+                                      "swift-abi-version: 1.0\n"
+                                      "...\n";
----------------
For TBD v4 the swift-abi-version should be just an integer. In this case it should be just 1.


================
Comment at: llvm/unittests/TextAPI/TextStubV4Tests.cpp:387
+                                         "install-name: Test.dylib\n"
+                                         "swift-abi-version: 1.1\n"
+                                         "...\n";
----------------
And here the swift-abi-version should be 2.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67529/new/

https://reviews.llvm.org/D67529