[PATCH] D67926: Fix endianness handling in AVR MC

[serge via Phabricator via llvm-commits]

serge-sans-paille created this revision.
serge-sans-paille added reviewers: dylanmckay, tstellar.
Herald added subscribers: llvm-commits, Jim, hiraditya.
Herald added a project: LLVM.

Instead of hand-written byteswap, use the proper method, which in turns fixes a portability issue.

Fix https://bugs.llvm.org/show_bug.cgi?id=43384


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D67926

Files:
  llvm/lib/Target/AVR/MCTargetDesc/AVRMCCodeEmitter.cpp


Index: llvm/lib/Target/AVR/MCTargetDesc/AVRMCCodeEmitter.cpp
===================================================================
--- llvm/lib/Target/AVR/MCTargetDesc/AVRMCCodeEmitter.cpp
+++ llvm/lib/Target/AVR/MCTargetDesc/AVRMCCodeEmitter.cpp
@@ -26,6 +26,7 @@
 #include "llvm/MC/MCSubtargetInfo.h"
 #include "llvm/Support/Casting.h"
 #include "llvm/Support/raw_ostream.h"
+#include "llvm/Support/EndianStream.h"
 
 #define DEBUG_TYPE "mccodeemitter"
 
@@ -273,9 +274,7 @@
 
   for (int64_t i = WordCount - 1; i >= 0; --i) {
     uint16_t Word = Words[i];
-
-    OS << (uint8_t) ((Word & 0x00ff) >> 0);
-    OS << (uint8_t) ((Word & 0xff00) >> 8);
+    support::endian::write(OS, Word, support::endianness::native);
   }
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67926.221370.patch
Type: text/x-patch
Size: 728 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190923/3481837a/attachment.bin>