[PATCH] D67564: [IR] allow fast-math-flags on phi of FP values

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D67564#1679431 <https://reviews.llvm.org/D67564#1679431>, @spatel wrote:

> In D67564#1679387 <https://reviews.llvm.org/D67564#1679387>, @lebedev.ri wrote:
>
> > I think this makes sense since `select` already has those attrs.
> >  But what should happen for non-fp phi's? Do those flags make sense on e.g. i32 ?
>
>
> Unless the definition of FPMathOperator is broken, we won't allow FMF on a non-FP type of phi/select.


Yes, that was the question.

> Or are you asking if things like nsw/nuw/exact make sense on a phi with integer type? I haven't thought about that...

No, that doesn't make sense. Those only make sense on actual instructions.

> (We can't have both FMF and wrapping/exact flags simultaneously because the underlying implementation shares the bits of SubclassOptionalData.)




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67564/new/

https://reviews.llvm.org/D67564