[PATCH] D67846: [InstCombine] (a+b) <= a && (a+b) != 0 -> (0-b) < a (PR43259)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1068
+            m_c_ICmp(UnsignedPred, m_Specific(Subtracted), m_Value(A))) &&
+      match(Subtracted, m_c_Add(m_Specific(A), m_Value(B))) &&
+      (ZeroICmp->hasOneUse() || UnsignedICmp->hasOneUse())) {
----------------
spatel wrote:
> It's confusing to call this "Subtracted" when we're matching an add. Rename to something more generic like "ZeroCmpOp"?
Yeah, that was an unfortunate name choice in retrospect..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67846/new/

https://reviews.llvm.org/D67846