[PATCH] D67846: [InstCombine] (a+b) <= a && (a+b) != 0 -> (0-b) < a (PR43259)
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 23 08:35:03 PDT 2019
spatel added inline comments.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1068
+ m_c_ICmp(UnsignedPred, m_Specific(Subtracted), m_Value(A))) &&
+ match(Subtracted, m_c_Add(m_Specific(A), m_Value(B))) &&
+ (ZeroICmp->hasOneUse() || UnsignedICmp->hasOneUse())) {
----------------
It's confusing to call this "Subtracted" when we're matching an add. Rename to something more generic like "ZeroCmpOp"?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67846/new/
https://reviews.llvm.org/D67846
More information about the llvm-commits
mailing list