[PATCH] D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation
David Stenberg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 23 07:55:30 PDT 2019
dstenb marked 3 inline comments as done.
dstenb added inline comments.
================
Comment at: llvm/test/Verifier/diexpression-entry-value.ll:7
+!1 = !DIExpression(DW_OP_constu, 0, DW_OP_LLVM_entry_value, 1, DW_OP_constu, 0)
+!2 = !DIExpression(DW_OP_LLVM_entry_value, 100, DW_OP_constu, 0)
----------------
aprantl wrote:
> This is testing that *any* of these expressions are malformed. You either want a more specific CHECK line or more tests.
Yes, thanks! I added checks for all three DIExpressions now.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67492/new/
https://reviews.llvm.org/D67492
More information about the llvm-commits
mailing list