[PATCH] D67845: SSP: [3/3] cmpxchg and addrspacecast can now trigger stack protection

[Paul Robinson via Phabricator via llvm-commits]

probinson marked an inline comment as done.
probinson added inline comments.


================
Comment at: llvm/lib/CodeGen/StackProtector.cpp:204-205
     }
     default:
       break;
     }
----------------
arsenm wrote:
> I think this should be changed to assume true on unhandled instructions in case of future additions
Hm so fail-safe; I'd need to add some more cases for things that are explicitly okay, like Load and AtomicRMW, maybe more.  I'll look at that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67845/new/

https://reviews.llvm.org/D67845