[PATCH] D67501: [clang-tidy] Fix relative path in header-filter.

[Dmitri Gribenko via Phabricator via llvm-commits]

gribozavr added a comment.

Sorry, I reverted this patch in r372601.

Unfortunately, it makes paths printed in clang-tidy'd diagnostics inconsistent with what `-header-filter` operates on.

For example, imagine that `file-filter.cpp` includes `header_alias.h`, which is a symlink to `header.h`. The diagnostics printed by clang-tidy refer to `header_alias.h`, however, after this patch, `-header-filter` logic calls `realpath()` and operates on `header.h` -- making it very difficult for users to understand how exactly to set up filters.

Also, note that paths in diagnostics don't collapse `foo/..` or symlinks.

We should only change both sides of path handling simultaneously (paths in diagnostics and paths in filters). However, since getting the user's preferred path is potentially very difficult when symlinks are present, I'm not sure if anything can be done here. Maybe only collapsing `foo/..` would be viable?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67501/new/

https://reviews.llvm.org/D67501