[PATCH] D67709: [ARM][MVE] Cleanup tail-predicated loop

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Thanks, looks good to me.

Nitpick/bikeshedding the title:

> Cleanup tail-predicated loop

This is accurate when you know what this is doing, but one could get the wrong impression, like this is a NFC patch. Perhaps something like:

"Finalise tail-predicated loop, remove duplicate predicates"

Or something along those lines.



================
Comment at: lib/Target/ARM/MVETailPredication.cpp:430
+        MaybeDead.insert(OpI);
+    }
+    I->dropAllReferences();
----------------
nit: don't need the brackets in this case (I just noticed because I started looking to see which blocks it closes as it is a bit difficult to see sometimes in phabricator).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67709/new/

https://reviews.llvm.org/D67709