[PATCH] D67851: llvm-undname: Add support for demangling typeinfo names

Mon Sep 23 01:54:42 PDT 2019

hans added inline comments.

================
Comment at: llvm/include/llvm/Demangle/MicrosoftDemangle.h:161
   SymbolNode *demangleMD5Name(StringView &MangledName);
+  SymbolNode *demangleTypeinfoName(StringView &MangledName);

----------------
mstorsjo wrote:
> hans wrote:
> > Off topic: Do you know why the demangler uses its own StringView class instead of StringRef like the rest of llvm?
> > 
> > (Looks like it comes from libcxxabi via this commit: r327859)
> The demangler can't use the normal llvm classes, as it is supposed to be able to run on top of plain C/C++ standard libraries (because it's shared with the demangling code in libcxxabi).
Ah, thanks for clarifying!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67851/new/

https://reviews.llvm.org/D67851