[PATCH] D66991: [PowerPC] Fix SH field overflow issue

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 22 20:19:18 PDT 2019


lkail added a comment.

I think the test can be simplified more, kinda like

  # RUN: llc -O3 -mtriple=powerpc64le-unknown-linux-gnu -stop-after=ppc-pre-emit-peephole -verify-machineinstrs %s -o - | FileCheck %s
  ---                                                                                                                                                                           
  name: foo                                                                                                                                                                   
  alignment: 4                                                                                                                                                                  
  tracksRegLiveness: true                                                                                                                                                       
  body: |                                                                                                                                                                       
    bb.0.entry:                                                                                                                                                                 
      liveins: $r3                                                                                                                                                              
      renamable $r4 = LI 0                                                                                                                                                      
      renamable $r5 = SRW renamable $r3, renamable killed $r4                                                                                                                   
      $r3 = COPY renamable killed $r5                                                                                                                                           
      BLR implicit $lr, implicit $rm, implicit $r3                                                                                                                              
  ...

And a NFC patch to pre-commit the test would also be preferable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66991/new/

https://reviews.llvm.org/D66991





More information about the llvm-commits mailing list