[PATCH] D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 22 12:54:15 PDT 2019


lebedev.ri updated this revision to Diff 221233.
lebedev.ri edited the summary of this revision.
lebedev.ri added a comment.

Scaling down ambigiousness of the patch: if not using BEXTR, only use BZHI if either the mask is larger than 32-bit, or the load folding will happen.

I'm not sure if it's okay to leave newly-created noted like that if we decide it's not worthwhile folding?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67875/new/

https://reviews.llvm.org/D67875

Files:
  llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
  llvm/test/CodeGen/X86/bmi-x86_64.ll
  llvm/test/CodeGen/X86/bmi.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67875.221233.patch
Type: text/x-patch
Size: 8562 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190922/28396918/attachment-0001.bin>


More information about the llvm-commits mailing list