[llvm] r372512 - gn build: consolidate "Nothing to do" branches in targets.gni

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 22 08:42:40 PDT 2019


Author: nico
Date: Sun Sep 22 08:42:40 2019
New Revision: 372512

URL: http://llvm.org/viewvc/llvm-project?rev=372512&view=rev
Log:
gn build: consolidate "Nothing to do" branches in targets.gni

No behavior change.

Modified:
    llvm/trunk/utils/gn/secondary/llvm/lib/Target/targets.gni

Modified: llvm/trunk/utils/gn/secondary/llvm/lib/Target/targets.gni
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/llvm/lib/Target/targets.gni?rev=372512&r1=372511&r2=372512&view=diff
==============================================================================
--- llvm/trunk/utils/gn/secondary/llvm/lib/Target/targets.gni (original)
+++ llvm/trunk/utils/gn/secondary/llvm/lib/Target/targets.gni Sun Sep 22 08:42:40 2019
@@ -39,7 +39,8 @@ if (llvm_targets_to_build == "host") {
 }
 
 # Validate that llvm_targets_to_build is set to a list of valid targets,
-# and remember which targets are built.
+# and remember which targets are built where needed (for conditionally-built
+# unittest targets).
 llvm_build_AArch64 = false
 llvm_build_ARM = false
 llvm_build_BPF = false
@@ -49,34 +50,20 @@ llvm_build_X86 = false
 foreach(target, llvm_targets_to_build) {
   if (target == "AArch64") {
     llvm_build_AArch64 = true
-  } else if (target == "AMDGPU") {
-    # Nothing to do.
   } else if (target == "ARM") {
     llvm_build_ARM = true
-  } else if (target == "AVR") {
-    # Nothing to do.
   } else if (target == "BPF") {
     llvm_build_BPF = true
-  } else if (target == "Hexagon") {
-    # Nothing to do.
-  } else if (target == "Lanai") {
-    # Nothing to do.
-  } else if (target == "Mips") {
-    # Nothing to do.
-  } else if (target == "NVPTX") {
-    # Nothing to do.
   } else if (target == "PowerPC") {
     llvm_build_PowerPC = true
-  } else if (target == "RISCV") {
-    # Nothing to do.
-  } else if (target == "Sparc") {
-    # Nothing to do.
-  } else if (target == "SystemZ") {
-    # Nothing to do.
   } else if (target == "WebAssembly") {
     llvm_build_WebAssembly = true
   } else if (target == "X86") {
     llvm_build_X86 = true
+  } else if (target == "AMDGPU" || target == "AVR" || target == "Hexagon" ||
+             target == "Lanai" || target == "Mips" || target == "NVPTX" ||
+             target == "RISCV" || target == "Sparc" || target == "SystemZ") {
+    # Nothing to do.
   } else {
     # FIXME: Port the remaining targets.
     assert(false, "Unknown target '$target'.")




More information about the llvm-commits mailing list