[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

[Andrzej Warzynski via Phabricator via llvm-commits]

andwar added inline comments.


================
Comment at: llvm/examples/Bye/Bye.cpp:53
+/* New PM Registration */
+
+llvm::PassPluginLibraryInfo getByePluginInfo() {
----------------
[nit] Empty line


================
Comment at: llvm/examples/Bye/CMakeLists.txt:9
+else()
+  target_link_libraries(Bye
+    PUBLIC
----------------
Are all these libraries required? I tried building on Darwin and for me `LLVMSupport`, `LLVMCore` and `LLVMipo` were sufficient.


================
Comment at: llvm/examples/Bye/CMakeLists.txt:28
+endif()
+
----------------
[nit] Empty line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61446/new/

https://reviews.llvm.org/D61446