[PATCH] D67756: [MIPS GlobalISel] VarArg argument lowering, select G_VASTART and vacopy
Simon Atanasyan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Sep 21 14:07:00 PDT 2019
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM wit a few nits
================
Comment at: lib/Target/Mips/MipsInstructionSelector.cpp:798
+ return true;
+ break;
+ }
----------------
The `break` is redundant after `return`.
================
Comment at: lib/Target/Mips/MipsLegalizerInfo.cpp:269
+ return true;
+ break;
+ }
----------------
ditto
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67756/new/
https://reviews.llvm.org/D67756
More information about the llvm-commits
mailing list