[PATCH] D67878: [LNT] Python 3 support: use Python 3 urllib
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Sep 21 11:14:18 PDT 2019
hubert.reinterpretcast added inline comments.
================
Comment at: lnt/util/ServerUtil.py:45
headers = {'Accept': 'application/json'}
- data = urllib.urlencode(values)
+ data = urllib.parse.urlencode(values).encode()
try:
----------------
I think `.encode(encoding='ascii')` makes it more clear that the Python 2 and Python 3 behavior of this is not going to diverge.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67878/new/
https://reviews.llvm.org/D67878
More information about the llvm-commits
mailing list