[PATCH] D67809: [LNT] Python 3 support: use Python 3 idioms
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Sep 21 07:41:11 PDT 2019
thopre added inline comments.
================
Comment at: lnt/external/stats/stats.py:2027
else: # must be a SEQUENCE of dims to average over
- dims = list(dimension)
- dims.sort()
+ dims = sorted(dimension)
dims.reverse()
----------------
hubert.reinterpretcast wrote:
> Should this sort be updated to sort in the desired order instead of calling `reverse()` after?
Good catch and good idea! Done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67809/new/
https://reviews.llvm.org/D67809
More information about the llvm-commits
mailing list